fix: tests for VLM calls #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
reviewed
Sep 10, 2025
Contributor
jakelorocco
left a comment
jakelorocco
left a comment
There was a problem hiding this comment.
looks like some of your tests are failing:
test/stdlib_basics/test_vision.py::test_image_block_in_instruction FAILED [ 81%]
test/stdlib_basics/test_vision.py::test_image_block_in_chat FAILED [ 82%]
Because your backend providers are different, it's expecting the images to be in different places. Might be worth making tests explicitly for those scenarios.
Contributor
Author
|
@jakelorocco I separated the tests for ollama vs openai style image prompts.. they should cover all styles of models for now. |
jakelorocco
approved these changes
Sep 10, 2025
Contributor
jakelorocco
left a comment
jakelorocco
left a comment
There was a problem hiding this comment.
lgtm; hopefully we can switch the gh action model to be a VLM as well and avoid the gh skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #128